Bug 170520 – Simple line layout: Hittest always returns the first renderer in the block.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

SSIA.

somewhat related: rdar://problem/30979175

[zalan]

Created attachment 306319 [details]
Patch

[Antti Koivisto]

Comment on attachment 306319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306319&action=review

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:134
> +        struct LineOverlap {
> +            FloatRect rect;
> +            const RenderObject& renderer;
> +        };

It would be good idea to add a FIXME here explaining how this is wrong (there can be multiple renderers per line).

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:142
> -        const FloatRect operator*() const;
> +        const LineOverlap operator*() const;

Maybe there could be a separate lineOverlap() function and keep the operator* as-is? Or do all clients need the renderer too?

[zalan]

Created attachment 306396 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 306396 [details]
Patch

Rejecting attachment 306396 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 306396, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3485805

[zalan]

Created attachment 306408 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 306408 [details]
Patch

Clearing flags on attachment: 306408

Committed r215054: <http://trac.webkit.org/changeset/215054>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.