Bug 170518 - Use the Accelerate framework to optimize FEColorMatrix operations
Summary: Use the Accelerate framework to optimize FEColorMatrix operations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-05 13:06 PDT by Simon Fraser (smfr)
Modified: 2017-04-06 17:02 PDT (History)
10 users (show)

See Also:

Attachments
Patch (16.71 KB, patch)
2017-04-05 13:08 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (915.77 KB, application/zip)
2017-04-05 14:09 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.69 MB, application/zip)
2017-04-05 14:27 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (940.85 KB, application/zip)
2017-04-05 14:37 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (874.25 KB, application/zip)
2017-04-05 14:40 PDT, Build Bot 		no flags Details
Patch (24.31 KB, patch)
2017-04-05 18:06 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (18.24 KB, patch)
2017-04-05 18:12 PDT, Simon Fraser (smfr) 		thorton: review+
thorton: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-04-05 13:06:54 PDT 
Use the Accelerate framework to optimize FEColorMatrix operations
Comment 1 Simon Fraser (smfr) 2017-04-05 13:08:02 PDT 
Created attachment 306305 [details]
Patch
Comment 2 Build Bot 2017-04-05 14:09:11 PDT 
Comment on attachment 306305 [details]
Patch

Attachment 306305 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3480314

New failing tests:
imported/blink/css3/filters/effect-reference-on-transparent-element.html
Comment 3 Build Bot 2017-04-05 14:09:12 PDT 
Created attachment 306312 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-04-05 14:27:04 PDT 
Comment on attachment 306305 [details]
Patch

Attachment 306305 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3480399

New failing tests:
imported/blink/css3/filters/effect-reference-on-transparent-element.html
Comment 5 Build Bot 2017-04-05 14:27:05 PDT 
Created attachment 306315 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-04-05 14:37:44 PDT 
Comment on attachment 306305 [details]
Patch

Attachment 306305 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3480608

New failing tests:
imported/blink/css3/filters/effect-reference-on-transparent-element.html
Comment 7 Build Bot 2017-04-05 14:37:46 PDT 
Created attachment 306317 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-04-05 14:40:15 PDT 
Comment on attachment 306305 [details]
Patch

Attachment 306305 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3480437

New failing tests:
imported/blink/css3/filters/effect-reference-on-transparent-element.html
Comment 9 Build Bot 2017-04-05 14:40:17 PDT 
Created attachment 306318 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Simon Fraser (smfr) 2017-04-05 18:06:57 PDT 
Created attachment 306350 [details]
Patch
Comment 11 Simon Fraser (smfr) 2017-04-05 18:12:30 PDT 
Created attachment 306351 [details]
Patch
Comment 12 Build Bot 2017-04-05 18:14:15 PDT 
Attachment 306351 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp:120:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Tim Horton 2017-04-06 15:58:16 PDT 
Comment on attachment 306351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306351&action=review

> Source/WebCore/ChangeLog:3
> +        Use the Accelerate framework to optimize FEColorMatrix operations

double changelog
Comment 14 Simon Fraser (smfr) 2017-04-06 17:02:04 PDT 
https://trac.webkit.org/r215069