Bug 170518 – Use the Accelerate framework to optimize FEColorMatrix operations

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Use the Accelerate framework to optimize FEColorMatrix operations

[Simon Fraser (smfr)]

Created attachment 306305 [details]
Patch

[Build Bot]

Comment on attachment 306305 [details]
Patch

Attachment 306305 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3480314

New failing tests:
imported/blink/css3/filters/effect-reference-on-transparent-element.html

[Build Bot]

Created attachment 306312 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306305 [details]
Patch

Attachment 306305 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3480399

New failing tests:
imported/blink/css3/filters/effect-reference-on-transparent-element.html

[Build Bot]

Created attachment 306315 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306305 [details]
Patch

Attachment 306305 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3480608

New failing tests:
imported/blink/css3/filters/effect-reference-on-transparent-element.html

[Build Bot]

Created attachment 306317 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306305 [details]
Patch

Attachment 306305 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3480437

New failing tests:
imported/blink/css3/filters/effect-reference-on-transparent-element.html

[Build Bot]

Created attachment 306318 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Simon Fraser (smfr)]

Created attachment 306350 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 306351 [details]
Patch

[Build Bot]

Attachment 306351 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp:120:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 306351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306351&action=review

> Source/WebCore/ChangeLog:3
> +        Use the Accelerate framework to optimize FEColorMatrix operations

double changelog

[Simon Fraser (smfr)]

https://trac.webkit.org/r215069