Bug 170516 - WebAssembly: Plans should be able to have more than one completion task.
Summary: WebAssembly: Plans should be able to have more than one completion task.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-05 12:48 PDT by Keith Miller
Modified: 2017-04-05 14:19 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.14 KB, patch)
2017-04-05 12:49 PDT, Keith Miller 		saam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (867.26 KB, application/zip)
2017-04-05 13:57 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-04-05 12:48:11 PDT 
WebAssembly: Plans should be able to have more than one completion task.
Comment 1 Keith Miller 2017-04-05 12:49:39 PDT 
Created attachment 306301 [details]
Patch
Comment 2 Saam Barati 2017-04-05 13:49:59 PDT 
Comment on attachment 306301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306301&action=review

> Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:-159
> -        vm.promiseDeferredTimer->scheduleBlockedTask(instance->codeBlock()->plan().pendingPromise(), [&vm, promise, instance, module, entries] () {

can we remove the pending promise stuff?
Comment 3 Build Bot 2017-04-05 13:57:17 PDT 
Comment on attachment 306301 [details]
Patch

Attachment 306301 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3480257

New failing tests:
fast/mediastream/getUserMedia-webaudio.html
Comment 4 Build Bot 2017-04-05 13:57:19 PDT 
Created attachment 306310 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 Keith Miller 2017-04-05 14:19:42 PDT 
Committed r214970: <http://trac.webkit.org/changeset/214970>