Bug 170504 – WebAssembly: We shouldn't need to pin size registers if we have a fast memory.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

WebAssembly: We shouldn't need to pin size registers if we have a fast memory.

[Keith Miller]

Created attachment 306281 [details]
Patch

[Build Bot]

Comment on attachment 306281 [details]
Patch

Attachment 306281 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3477981

New failing tests:
imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-worker.html

[Build Bot]

Created attachment 306282 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Mark Lam]

Comment on attachment 306281 [details]
Patch

r=me

[Saam Barati]

Comment on attachment 306281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306281&action=review

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:328
> +            m_proc.pinRegister(regInfo.sizeRegister);

I wonder if we should just rid the code base of the notion of multiple size registers. It's weird we have code that tries to handle it, but we don't even know if it works.

[Keith Miller]

rdar://problem/31107374

[Keith Miller]

Comment on attachment 306281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306281&action=review

>> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:328
>> +            m_proc.pinRegister(regInfo.sizeRegister);
> 
> I wonder if we should just rid the code base of the notion of multiple size registers. It's weird we have code that tries to handle it, but we don't even know if it works.

Yeah, it might be worthwhile. I initially made the abstraction since Fil seemed interested. Either way, I think it should happen in another patch.

[Keith Miller]

Committed r214950: <http://trac.webkit.org/changeset/214950>