Patch forthcoming.
Created attachment 306230 [details] the patch
Attachment 306230 [details] did not pass style-queue: ERROR: Source/WTF/wtf/IndexSparseSet.h:204: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 306230 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=306230&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + changes to make this phase run faster. This is a ~7% wasm -O1 compile time progression. awesome > Source/WTF/wtf/IndexSparseSet.h:47 > + typedef T EntryType; style nit: can be "using". > Source/WTF/wtf/IndexSparseSet.h:57 > + static T create(T entry) > + { > + return entry; > + } > + > + static T key(T entry) > + { > + return entry; > + } maybe these should take "const T& entry"? > Source/WTF/wtf/IndexSparseSet.h:62 > + typedef KeyValuePair<KeyType, ValueType> EntryType; ditto on "using".
(In reply to Saam Barati from comment #3) > Comment on attachment 306230 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306230&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:10 > > + changes to make this phase run faster. This is a ~7% wasm -O1 compile time progression. > > awesome > > > Source/WTF/wtf/IndexSparseSet.h:47 > > + typedef T EntryType; > > style nit: can be "using". > > > Source/WTF/wtf/IndexSparseSet.h:57 > > + static T create(T entry) > > + { > > + return entry; > > + } > > + > > + static T key(T entry) > > + { > > + return entry; > > + } > > maybe these should take "const T& entry"? I'll clean this up. > > > Source/WTF/wtf/IndexSparseSet.h:62 > > + typedef KeyValuePair<KeyType, ValueType> EntryType; > > ditto on "using". I still like typedef in those cases where it's legal. Do we have to switch to using?
Landed in https://trac.webkit.org/changeset/214917/webkit