Bug 170481 - Add JF Bastien as reviewer 🎉
Summary: Add JF Bastien as reviewer 🎉
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-04 15:38 PDT by JF Bastien
Modified: 2022-02-28 03:35 PST (History)
5 users (show)

See Also:

Attachments
patch (1.39 KB, patch)
2017-04-04 15:40 PDT, JF Bastien 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2017-04-04 15:38:28 PDT 
🍾
Comment 1 JF Bastien 2017-04-04 15:40:02 PDT 
Created attachment 306221 [details]
patch

🎉
Comment 2 Build Bot 2017-04-04 15:41:58 PDT 
Attachment 306221 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2017-04-04 15:42:55 PDT 
Comment on attachment 306221 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306221&action=review

r=me with fixes.  For future reference, you don't need a bug and a review for this change.  A ChangeLog entry is needed though.

> Tools/ChangeLog:3
> +        Add JF Bastien as reviewer ð

Can you remove the non-ascii char?

> Tools/Scripts/webkitpy/common/config/contributors.json:-5831
> -}
>  \ No newline at end of file
> +}
> -- 

Revert this please.
Comment 4 JF Bastien 2017-04-04 15:49:55 PDT 
https://trac.webkit.org/changeset/214909/webkit