Bug 170477 - Web Inspector: RTL: fix alignment of "truncated call stack" message
Summary: Web Inspector: RTL: fix alignment of "truncated call stack" message
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-04 15:11 PDT by BJ Burg
Modified: 2022-03-01 02:37 PST (History)
3 users (show)

See Also:

Attachments
LTR - before (43.19 KB, image/png)
2017-04-04 15:11 PDT, BJ Burg 		no flags Details
RTL - before (34.22 KB, image/png)
2017-04-04 15:12 PDT, BJ Burg 		no flags Details
RTL - after (53.44 KB, image/png)
2017-04-04 15:12 PDT, BJ Burg 		no flags Details
Proposed Fix (3.35 KB, patch)
2017-04-04 15:13 PDT, BJ Burg 		hi: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-04-04 15:11:44 PDT 
oops.
Comment 1 BJ Burg 2017-04-04 15:11:58 PDT 
Created attachment 306212 [details]
LTR - before
Comment 2 BJ Burg 2017-04-04 15:12:06 PDT 
Created attachment 306213 [details]
RTL - before
Comment 3 BJ Burg 2017-04-04 15:12:21 PDT 
Created attachment 306214 [details]
RTL - after
Comment 4 BJ Burg 2017-04-04 15:13:21 PDT 
Created attachment 306215 [details]
Proposed Fix
Comment 5 Devin Rousso 2017-04-04 16:18:17 PDT 
Comment on attachment 306215 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=306215&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css:66
> +    margin-left: var(--truncated-call-frames-margin-start);
> +    margin-right: var(--truncated-call-frames-margin-end);

NIT: I prefer to follow the shorthand order when using longhand properties.

margin-right: var(--truncated-call-frames-margin-end);
margin-left: var(--truncated-call-frames-margin-start);
Comment 6 BJ Burg 2017-04-27 16:12:28 PDT 
Committed r215903: <http://trac.webkit.org/changeset/215903>