Bug 170471 - Move AVSampleBufferDisplayLayer declarations into AVFoundationSPI.h
Summary: Move AVSampleBufferDisplayLayer declarations into AVFoundationSPI.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 170491
Blocks:
  Show dependency tree / graph
 
Reported: 2017-04-04 14:18 PDT by Jer Noble
Modified: 2017-04-04 22:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.90 KB, patch)
2017-04-04 14:20 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (5.33 KB, patch)
2017-04-04 21:59 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-04-04 14:18:36 PDT 
Move AVSampleBufferDisplayLayer declarations into AVFoundationSPI.h
Comment 1 Jer Noble 2017-04-04 14:20:23 PDT 
Created attachment 306204 [details]
Patch
Comment 2 WebKit Commit Bot 2017-04-04 15:30:07 PDT 
Comment on attachment 306204 [details]
Patch

Clearing flags on attachment: 306204

Committed r214907: <http://trac.webkit.org/changeset/214907>
Comment 3 WebKit Commit Bot 2017-04-04 15:30:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Jer Noble 2017-04-04 16:33:14 PDT 
Follow up build fix: Committed r214912: <https://trac.webkit.org/r214912>
Comment 5 WebKit Commit Bot 2017-04-04 20:23:45 PDT 
Re-opened since this is blocked by bug 170491
Comment 6 Jer Noble 2017-04-04 21:59:24 PDT 
Created attachment 306250 [details]
Patch for landing
Comment 7 Build Bot 2017-04-04 22:00:53 PDT 
Attachment 306250 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/mac/AVFoundationSPI.h:198:  Missing spaces around /  [whitespace/operators] [3]
ERROR: Source/WebCore/platform/spi/mac/AVFoundationSPI.h:224:  Missing spaces around /  [whitespace/operators] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2017-04-04 22:38:29 PDT 
Comment on attachment 306250 [details]
Patch for landing

Clearing flags on attachment: 306250

Committed r214930: <http://trac.webkit.org/changeset/214930>
Comment 9 WebKit Commit Bot 2017-04-04 22:38:30 PDT 
All reviewed patches have been landed.  Closing bug.