RESOLVED FIXED 170470
Web Inspector: Include more Network information in Resource Details Sidebar
https://bugs.webkit.org/show_bug.cgi?id=170470
Summary Web Inspector: Include more Network information in Resource Details Sidebar
Joseph Pecoraro
Reported 2017-04-04 14:16:34 PDT
Summary: Include more Network information in Resource Details Sidebar * Include: IP Address, Connection ID, (Memory) / (Disk) Cache Info * Rename: "Connection" => "Connection ID" to make it a little clearer * Better string for Protocol Name (keep tooltip to show the ALPN identifier) Notes: * I think its better to show the shorter ALPN Protocol Identifier in the table (h2, http/1.1, etc) because they are easier to notice differences instead of showing a display name like "HTTP/1.1" and "HTTP/2". The identifier will still be available in the sidebar in a tooltip. * Switched "Remote Address" to "IP Address". It is shorter and that is what people are thinking to look for. I think developers are far more likely to understand this is the remote IP address and not the local IP address anyways.
Attachments
[PATCH] Proposed Fix (15.69 KB, patch)
2017-04-04 14:19 PDT, Joseph Pecoraro
no flags
[IMAGE] New Sidebar Data (783.91 KB, image/png)
2017-04-04 14:20 PDT, Joseph Pecoraro
no flags
Joseph Pecoraro
Comment 1 2017-04-04 14:19:10 PDT
Created attachment 306202 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2017-04-04 14:20:10 PDT
Created attachment 306203 [details] [IMAGE] New Sidebar Data
Blaze Burg
Comment 3 2017-04-04 14:46:54 PDT
Comment on attachment 306202 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306202&action=review r=me, nice. > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:202 > +localizedStrings["Connection ID"] = "Connection ID"; ID or identifier?
Joseph Pecoraro
Comment 4 2017-04-04 15:09:48 PDT
(In reply to Brian Burg from comment #3) > Comment on attachment 306202 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306202&action=review > > r=me, nice. > > > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:202 > > +localizedStrings["Connection ID"] = "Connection ID"; > > ID or identifier? Because this is a table header a long name just gets truncated. Let's go with the shorter name.
WebKit Commit Bot
Comment 5 2017-04-04 15:14:34 PDT
Comment on attachment 306202 [details] [PATCH] Proposed Fix Clearing flags on attachment: 306202 Committed r214903: <http://trac.webkit.org/changeset/214903>
WebKit Commit Bot
Comment 6 2017-04-04 15:14:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.