Bug 170468 - Change Document's lastHandledUserGestureTimestamp to be a MonotonicTime
Summary: Change Document's lastHandledUserGestureTimestamp to be a MonotonicTime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-04 13:48 PDT by Simon Fraser (smfr)
Modified: 2017-04-04 14:32 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.27 KB, patch)
2017-04-04 13:49 PDT, Simon Fraser (smfr)
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-04-04 13:48:50 PDT
Change Document's lastHandledUserGestureTimestamp to be a MonotonicTime
Comment 1 Simon Fraser (smfr) 2017-04-04 13:49:31 PDT
Created attachment 306196 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-04-04 14:32:58 PDT
https://trac.webkit.org/r214900
Comment 3 Chris Dumez 2017-04-04 14:32:59 PDT
Comment on attachment 306196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306196&action=review

> Source/WebCore/loader/FrameLoader.cpp:3039
> +    bool userDidInteractWithPage = static_cast<bool>(document.topDocument().lastHandledUserGestureTimestamp());

I personally like:
!!document.topDocument().lastHandledUserGestureTimestamp()

for this sort of things as it is shorter than a cast.