Bug 170465 - Various settings in Minibrowser are off by default, and should be on
Summary: Various settings in Minibrowser are off by default, and should be on
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-04 13:03 PDT by Said Abou-Hallawa
Modified: 2017-04-04 16:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2017-04-04 13:05 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2017-04-04 15:49 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2017-04-04 13:03:59 PDT 
In Minibrowser, the settings to enable async image decoding for large and animated imaages are off by default. When running "defaults delete org.webkit.MiniBrowser" and then opening Minibrowser, the async image decoding settings should be turned on by default.
Comment 1 Said Abou-Hallawa 2017-04-04 13:04:54 PDT 
<rdar://problem/31421543>
Comment 2 Said Abou-Hallawa 2017-04-04 13:05:52 PDT 
Created attachment 306188 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-04-04 13:36:20 PDT 
Comment on attachment 306188 [details]
Patch

Actually this same problem occurs with lots of other prefs. I think we need to detect when the prefs don't exist, and init stuff from WK1/WK2 prefs.
Comment 4 Simon Fraser (smfr) 2017-04-04 13:36:42 PDT 
You can give this bug to me if you want.
Comment 5 Simon Fraser (smfr) 2017-04-04 15:49:33 PDT 
Created attachment 306223 [details]
Patch
Comment 6 Tim Horton 2017-04-04 15:54:08 PDT 
Comment on attachment 306223 [details]
Patch

I don't love it, but it's better than the alternatives.
Comment 7 WebKit Commit Bot 2017-04-04 16:32:07 PDT 
Comment on attachment 306223 [details]
Patch

Clearing flags on attachment: 306223

Committed r214911: <http://trac.webkit.org/changeset/214911>
Comment 8 WebKit Commit Bot 2017-04-04 16:32:08 PDT 
All reviewed patches have been landed.  Closing bug.