Bug 170448 - AX: Don't crash if no renderer is available for AccessibilityRenderObject
Summary: AX: Don't crash if no renderer is available for AccessibilityRenderObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Tomas Popela
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-04 04:10 PDT by Tomas Popela
Modified: 2017-04-07 04:59 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.49 KB, patch)
2017-04-04 04:21 PDT, Tomas Popela 		no flags Details | Formatted Diff | Diff
Patch (2.55 KB, patch)
2017-04-06 02:48 PDT, Tomas Popela 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2017-04-04 04:10:10 PDT 
Don't crash or assert if no renderer is available, but early return gracefully (as in other places in the AccessibilityRenderObject.cpp). Spotted by running some tests through dogtail.
Comment 1 Tomas Popela 2017-04-04 04:21:55 PDT 
Created attachment 306170 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-04-04 04:22:40 PDT 
<rdar://problem/31425088>
Comment 3 chris fleizach 2017-04-04 07:01:54 PDT 
Comment on attachment 306170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306170&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:535
> +        return false;

I think if this was true I would be more accurate
Comment 4 Tomas Popela 2017-04-06 02:48:47 PDT 
Created attachment 306372 [details]
Patch
Comment 5 Tomas Popela 2017-04-07 04:59:36 PDT 
Comment on attachment 306372 [details]
Patch

Clearing flags on attachment: 306372

Committed r215089: <http://trac.webkit.org/changeset/215089>
Comment 6 Tomas Popela 2017-04-07 04:59:42 PDT 
All reviewed patches have been landed.  Closing bug.