Bug 170445 – space-evenly misbehaves with flexbox

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Florian Rivoal]

Created attachment 306166 [details]
failing test case

"justify-content: space-evenly" is implemented for grid layout, but not for flexbox, where instead it behaves as flex-start.

However, since it parses correctly, it is not possible to use the cascade (or @supports) fallback on some other value, making something like this unusable:

.foo {
  display: flex;
  justify-content: space-around; /* fallback if the next line is not supported */
  justify-content: space-evenly;
}

Ideally, space-evenly should be implemented in full for flexbox as well (mozilla already has it), but if that's too consuming for a quick fix, as a stop gap measure, using its default fallback alignment (center) would be much better than flex-start. Using space-around would probably be OK as well, as these two values are somewhat close.

I've attached a test-case (also submitted to wpt https://github.com/w3c/web-platform-tests/pull/5336) that currently fails, and would pass if either a full implementation was done, or if a fallback to either center or space-around was implemented instead.

[Javier Fernandez]

Created attachment 308171 [details]
Patch

[Dave Hyatt]

Comment on attachment 308171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308171&action=review

r=me

> LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html:47
> +<div data-offset-y="0">This text should be at the top of it's container</div>

Remove the apostrophe in it's. Shouldn't be there.

[Javier Fernandez]

Created attachment 309516 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 309516 [details]
Patch

Rejecting attachment 309516 [details] from commit-queue.

New failing tests:
css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html
Full output: http://webkit-queues.webkit.org/results/3706929

[WebKit Commit Bot]

Created attachment 309521 [details]
Archive of layout-test-results from webkit-cq-01 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Javier Fernandez]

Created attachment 309528 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 309528 [details]
Patch

Clearing flags on attachment: 309528

Committed r216536: <http://trac.webkit.org/changeset/216536>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.