Bug 170430 - TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
Summary: TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-03 16:04 PDT by Joseph Pecoraro
Modified: 2017-04-07 17:33 PDT (History)
6 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (76.02 KB, patch)
2017-04-03 16:10 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-04-03 16:04:53 PDT
When building TestWebKitAPI there is a warning:
Warning: Multiple build commands for output file /Build/Release/TestWebKitAPI.resources/Ahem.ttf

There are two identical copies of Ahem.ttf in the project. We only need one.
Comment 1 Joseph Pecoraro 2017-04-03 16:10:08 PDT
Created attachment 306135 [details]
[PATCH] Proposed Fix

Tested with:

    $ rm -rf $build/TestWebKitAPI*
    $ run-api-tests WebKit1.CancelLoadFromResourceLoadDelegate CancelLoading.CancelFontSubresource
    Running build-api-tests
    PASS CancelLoading.CancelFontSubresource
    PASS WebKit1.CancelLoadFromResourceLoadDelegate

This will make it harder to just open TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html from the source directory, because "Ahem.ttf" is not in that directory but we use the one in TestWebKitAPI/Tests/WebKit2/Ahem.ttf. I think thats fine, because what really matters is run-api-tests.
Comment 2 Joseph Pecoraro 2017-04-03 16:10:33 PDT
>     $ rm -rf $build/TestWebKitAPI*

Err, in this case $build/Release/TestWebKitAPI*
Comment 3 WebKit Commit Bot 2017-04-03 17:42:57 PDT
Comment on attachment 306135 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 306135

Committed r214858: <http://trac.webkit.org/changeset/214858>
Comment 4 WebKit Commit Bot 2017-04-03 17:42:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Myles C. Maxfield 2017-04-07 17:33:12 PDT
Thanks, Joe!