Bug 170425 - Web Inspector: RTL: layout issues in debugger dashboard, arrows are on wrong side
Summary: Web Inspector: RTL: layout issues in debugger dashboard, arrows are on wrong ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-03 15:25 PDT by Brian Burg
Modified: 2017-04-04 14:30 PDT (History)
4 users (show)

See Also:


Attachments
Proposed Fix (8.61 KB, patch)
2017-04-03 15:29 PDT, Brian Burg
no flags Details | Formatted Diff | Diff
RTL - debug dashboard - before (32.81 KB, image/png)
2017-04-03 15:29 PDT, Brian Burg
no flags Details
RTL - default dashboard - before (21.65 KB, image/png)
2017-04-03 15:30 PDT, Brian Burg
no flags Details
RTL - debug dashboard - after (32.66 KB, image/png)
2017-04-03 15:30 PDT, Brian Burg
no flags Details
LTR - debug dashboard - after (32.86 KB, image/png)
2017-04-03 15:30 PDT, Brian Burg
no flags Details
For Landing (8.63 KB, patch)
2017-04-04 13:10 PDT, Brian Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2017-04-03 15:25:30 PDT
Whoopsy.
Comment 1 Brian Burg 2017-04-03 15:29:09 PDT
Created attachment 306125 [details]
Proposed Fix
Comment 2 Brian Burg 2017-04-03 15:29:59 PDT
Created attachment 306126 [details]
RTL - debug dashboard - before
Comment 3 Brian Burg 2017-04-03 15:30:18 PDT
Created attachment 306127 [details]
RTL - default dashboard - before
Comment 4 Brian Burg 2017-04-03 15:30:37 PDT
Created attachment 306128 [details]
RTL - debug dashboard - after
Comment 5 Brian Burg 2017-04-03 15:30:53 PDT
Created attachment 306129 [details]
LTR - debug dashboard - after
Comment 6 Devin Rousso 2017-04-03 15:31:28 PDT
Comment on attachment 306125 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=306125&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css:152
> +    --dashboard-advance-arrow-end: 0px;

I think we are using "offset" to represent positioning values in CSS variable names.

--dashboard-advance-arrow-offset-end: 0;
Comment 7 Brian Burg 2017-04-03 23:33:13 PDT
(In reply to Devin Rousso from comment #6)
> Comment on attachment 306125 [details]
> Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306125&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css:152
> > +    --dashboard-advance-arrow-end: 0px;
> 
> I think we are using "offset" to represent positioning values in CSS
> variable names.
> 
> --dashboard-advance-arrow-offset-end: 0;

OK
Comment 8 Brian Burg 2017-04-04 13:10:07 PDT
Created attachment 306189 [details]
For Landing
Comment 9 WebKit Commit Bot 2017-04-04 14:30:07 PDT
The commit-queue encountered the following flaky tests while processing attachment 306189 [details]:

media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2017-04-04 14:30:33 PDT
Comment on attachment 306189 [details]
For Landing

Clearing flags on attachment: 306189

Committed r214899: <http://trac.webkit.org/changeset/214899>
Comment 11 WebKit Commit Bot 2017-04-04 14:30:34 PDT
All reviewed patches have been landed.  Closing bug.