Bug 170424 – AX: Expose link children when doing search predication on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

Since the children of the links are exposed on iOS instead of the link itself most of the time. We should expose the children when doing search predication.

[Nan Wang]

<rdar://problem/31413335>

[Nan Wang]

Created attachment 306123 [details]
patch

[chris fleizach]

Comment on attachment 306123 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306123&action=review

> Source/WebCore/ChangeLog:7
> +        Since the children of the links are exposed on iOS instead of the link itself

The children of links are accessible elements on iOS instead of the link itself, so we should expose the children when doing predicated searches as well.

> Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:665
> +    NSDictionary *parameterizedAttribute = searchPredicateParameterizedAttributeForSearchCriteria(context, startElement, isDirectionNext, 5, searchKey, searchText, visibleOnly, immediateDescendantsOnly);

any reason you chose five?

[Nan Wang]

Comment on attachment 306123 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306123&action=review

>> Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:665
>> +    NSDictionary *parameterizedAttribute = searchPredicateParameterizedAttributeForSearchCriteria(context, startElement, isDirectionNext, 5, searchKey, searchText, visibleOnly, immediateDescendantsOnly);
> 
> any reason you chose five?

I just picked a number thats greater than 1, and I think 5 should be enough for normal test cases. Do you have any suggestion ?

[chris fleizach]

Comment on attachment 306123 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306123&action=review

>>> Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:665
>>> +    NSDictionary *parameterizedAttribute = searchPredicateParameterizedAttributeForSearchCriteria(context, startElement, isDirectionNext, 5, searchKey, searchText, visibleOnly, immediateDescendantsOnly);
>> 
>> any reason you chose five?
> 
> I just picked a number thats greater than 1, and I think 5 should be enough for normal test cases. Do you have any suggestion ?

probably fine as is

[Nan Wang]

Created attachment 306132 [details]
patch

updated from review

[WebKit Commit Bot]

Comment on attachment 306132 [details]
patch

Clearing flags on attachment: 306132

Committed r214851: <http://trac.webkit.org/changeset/214851>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.