Bug 170414 - Support InputEvent.isComposing
Summary: Support InputEvent.isComposing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL: https://w3c.github.io/uievents/#dom-i...
Keywords: FromImplementor, InRadar
Depends on:
Blocks:
 
Reported: 2017-04-03 13:25 PDT by Chong Zhang
Modified: 2023-10-01 17:48 PDT (History)
11 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chong Zhang 2017-04-03 13:25:09 PDT 
According to spec https://w3c.github.io/uievents/#events-inputevents InputEvent should have attribute |isComposing| to indicate whether it's inside a composition.

Blink IDL:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/events/InputEvent.idl?q=InputEvent.idl&sq=package:chromium&dr&l=16
Comment 1 Wenson Hsieh 2017-04-23 23:18:25 PDT 
<rdar://problem/31781958>
Comment 2 Ahmad Saleem 2022-09-02 15:46:51 PDT 
Updated link to Chromium / Blink source - https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/events/input_event.idl;l=1?q=INput_event.idl&sq=

Webkit Source - https://github.com/WebKit/WebKit/blob/8afe31a018b11741abdf9b4d5bb973d7c1d9ff05/Source/WebCore/dom/InputEvent.idl

_____________

Need to change:

    constructor(DOMString type, optional InputEventInit eventInitDict = {});

Add:

    readonly attribute boolean isComposing;

Extra in Webkit:

dictionary InputEventInit : UIEventInit {
    DOMString? data = null;
};
Comment 3 Ryosuke Niwa 2022-09-03 03:22:04 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3990
Comment 4 EWS 2022-09-03 10:53:44 PDT 
Committed 254131@main (1aeb3328d18e): <https://commits.webkit.org/254131@main>

Reviewed commits have been landed. Closing PR #3990 and removing active labels.