Bug 170381 – Mac cmake buildfix after 214586

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:27:
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:29:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/BlockPtr.h:86:48: error: use of undeclared identifier 'std'
            return static_cast<Block*>(ptr)->f(std::forward<Args>(args)...);
                                               ^

...

In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:31:
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/DerivedSources/ForwardingHeaders/WebCore/CoreGraphicsSPI.h:1:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:37:10: fatal error: 'ColorSync/ColorSync.h' file not found
#include <ColorSync/ColorSync.h>
         ^

[Csaba Osztrogonác]

Created attachment 306046 [details]
Patch

patch for EWS

[Csaba Osztrogonác]

Comment on attachment 306046 [details]
Patch

Clearing flags on attachment: 306046

Committed r214716: <http://trac.webkit.org/changeset/214716>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Committed r214717: <http://trac.webkit.org/changeset/214717>

[Csaba Osztrogonác]

forgot to mention https://trac.webkit.org/changeset/214715/webkit
which was the first fix after the following build error:

/Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:29:9: fatal error: 'EventSerializerMac.h' file not found
#import "EventSerializerMac.h"
        ^

[Csaba Osztrogonác]

Still broken ...

Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_EventStreamPlayer", referenced from:
      objc-class-ref in UIScriptControllerMac.mm.o
  "beginSwipeBackEventStream()", referenced from:
      WTR::UIScriptController::beginBackSwipe(OpaqueJSValue const*) in UIScriptControllerMac.mm.o
  "completeSwipeBackEventStream()", referenced from:
      WTR::UIScriptController::completeBackSwipe(OpaqueJSValue const*) in UIScriptControllerMac.mm.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/WebKitTestRunner] Error 1
make[1]: *** [Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/all] Error 2

...

/Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:59:38: error: unknown type name 'CGSEventType'; did you mean 'CGEventType'?
bool eventIsOfType(CGEventRef event, CGSEventType type)
                                     ^~~~~~~~~~~~
                                     CGEventType
...

[Csaba Osztrogonác]

unassign, I don't have time for it, maybe Alex?

[Alex Christensen]

https://trac.webkit.org/changeset/214946/webkit