Bug 170381 - Mac cmake buildfix after 214586
Summary: Mac cmake buildfix after 214586
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 161675
  Show dependency treegraph
Reported: 2017-04-01 04:00 PDT by Csaba Osztrogonác
Modified: 2017-04-05 18:52 PDT (History)
9 users (show)

See Also:

Patch (908 bytes, patch)
2017-04-01 04:03 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2017-04-01 04:00:19 PDT
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:27:
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:29:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/BlockPtr.h:86:48: error: use of undeclared identifier 'std'
            return static_cast<Block*>(ptr)->f(std::forward<Args>(args)...);


In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:31:
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/DerivedSources/ForwardingHeaders/WebCore/CoreGraphicsSPI.h:1:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:37:10: fatal error: 'ColorSync/ColorSync.h' file not found
#include <ColorSync/ColorSync.h>
Comment 1 Csaba Osztrogonác 2017-04-01 04:03:23 PDT
Created attachment 306046 [details]

patch for EWS
Comment 2 Csaba Osztrogonác 2017-04-01 05:35:28 PDT
Comment on attachment 306046 [details]

Clearing flags on attachment: 306046

Committed r214716: <http://trac.webkit.org/changeset/214716>
Comment 3 Csaba Osztrogonác 2017-04-01 05:35:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2017-04-01 05:48:38 PDT
Committed r214717: <http://trac.webkit.org/changeset/214717>
Comment 5 Csaba Osztrogonác 2017-04-01 06:51:34 PDT
forgot to mention https://trac.webkit.org/changeset/214715/webkit
which was the first fix after the following build error:

/Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:29:9: fatal error: 'EventSerializerMac.h' file not found
#import "EventSerializerMac.h"
Comment 6 Csaba Osztrogonác 2017-04-01 07:15:46 PDT
Still broken ...

Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_EventStreamPlayer", referenced from:
      objc-class-ref in UIScriptControllerMac.mm.o
  "beginSwipeBackEventStream()", referenced from:
      WTR::UIScriptController::beginBackSwipe(OpaqueJSValue const*) in UIScriptControllerMac.mm.o
  "completeSwipeBackEventStream()", referenced from:
      WTR::UIScriptController::completeBackSwipe(OpaqueJSValue const*) in UIScriptControllerMac.mm.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/WebKitTestRunner] Error 1
make[1]: *** [Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/all] Error 2


/Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:59:38: error: unknown type name 'CGSEventType'; did you mean 'CGEventType'?
bool eventIsOfType(CGEventRef event, CGSEventType type)
Comment 7 Csaba Osztrogonác 2017-04-03 06:26:26 PDT
unassign, I don't have time for it, maybe Alex?
Comment 8 Alex Christensen 2017-04-05 18:52:20 PDT