Bug 170378 – WebAssembly: webAssemblyB3OptimizationLevel should use defaultB3OptLevel by default

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

WebAssembly: webAssemblyB3OptimizationLevel should use defaultB3OptLevel by default

[Keith Miller]

Created attachment 306037 [details]
Patch

[Saam Barati]

Comment on attachment 306037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306037&action=review

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:51
> +Expected<std::unique_ptr<WasmInternalFunction>, String> parseAndCompile(CompilationContext&, const uint8_t*, size_t, const Signature&, Vector<UnlinkedWasmToWasmCall>&, const ModuleInformation&, const Vector<SignatureIndex>&, MemoryMode, unsigned optLevel);

You don't need to make the callers of this function pass in a value?

[Keith Miller]

(In reply to Saam Barati from comment #2)
> Comment on attachment 306037 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306037&action=review
> 
> > Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:51
> > +Expected<std::unique_ptr<WasmInternalFunction>, String> parseAndCompile(CompilationContext&, const uint8_t*, size_t, const Signature&, Vector<UnlinkedWasmToWasmCall>&, const ModuleInformation&, const Vector<SignatureIndex>&, MemoryMode, unsigned optLevel);
> 
> You don't need to make the callers of this function pass in a value?

I fixed that when I added the option. the default value is just unused atm.

[Keith Miller]

Committed r214709: <http://trac.webkit.org/changeset/214709>