Bug 170378 - WebAssembly: webAssemblyB3OptimizationLevel should use defaultB3OptLevel by default
Summary: WebAssembly: webAssemblyB3OptimizationLevel should use defaultB3OptLevel by d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-31 18:48 PDT by Keith Miller
Modified: 2017-03-31 18:54 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2017-03-31 18:48 PDT, Keith Miller 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-03-31 18:48:21 PDT 
WebAssembly: webAssemblyB3OptimizationLevel should use defaultB3OptLevel by default
Comment 1 Keith Miller 2017-03-31 18:48:44 PDT 
Created attachment 306037 [details]
Patch
Comment 2 Saam Barati 2017-03-31 18:53:02 PDT 
Comment on attachment 306037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306037&action=review

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:51
> +Expected<std::unique_ptr<WasmInternalFunction>, String> parseAndCompile(CompilationContext&, const uint8_t*, size_t, const Signature&, Vector<UnlinkedWasmToWasmCall>&, const ModuleInformation&, const Vector<SignatureIndex>&, MemoryMode, unsigned optLevel);

You don't need to make the callers of this function pass in a value?
Comment 3 Keith Miller 2017-03-31 18:54:37 PDT 
(In reply to Saam Barati from comment #2)
> Comment on attachment 306037 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306037&action=review
> 
> > Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:51
> > +Expected<std::unique_ptr<WasmInternalFunction>, String> parseAndCompile(CompilationContext&, const uint8_t*, size_t, const Signature&, Vector<UnlinkedWasmToWasmCall>&, const ModuleInformation&, const Vector<SignatureIndex>&, MemoryMode, unsigned optLevel);
> 
> You don't need to make the callers of this function pass in a value?

I fixed that when I added the option. the default value is just unused atm.
Comment 4 Keith Miller 2017-03-31 18:54:59 PDT 
Committed r214709: <http://trac.webkit.org/changeset/214709>