Bug 170374 - WebAssembly: Add compilation level option
Summary: WebAssembly: Add compilation level option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-31 17:41 PDT by Keith Miller
Modified: 2017-03-31 17:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.14 KB, patch)
2017-03-31 17:44 PDT, Keith Miller 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-03-31 17:41:37 PDT 
WebAssembly: Add compilation level option
Comment 1 Keith Miller 2017-03-31 17:44:28 PDT 
Created attachment 306031 [details]
Patch
Comment 2 Mark Lam 2017-03-31 17:46:39 PDT 
Comment on attachment 306031 [details]
Patch

r=me
Comment 3 Keith Miller 2017-03-31 17:48:01 PDT 
Committed r214708: <http://trac.webkit.org/changeset/214708>
Comment 4 Mark Lam 2017-03-31 17:48:21 PDT 
Comment on attachment 306031 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306031&action=review

> Source/JavaScriptCore/wasm/WasmPlan.cpp:248
> +        auto parseAndCompileResult = parseAndCompile(m_compilationContexts[functionIndex], functionStart, functionLength, signature, m_unlinkedWasmToWasmCalls[functionIndex], *m_moduleInformation, m_moduleSignatureIndicesToUniquedSignatureIndices, m_mode, Options::webAssemblyB3OptimizationLevel());

The current implementation uses "unsigned optLevel = B3::defaultOptLevel()" in the header file.  Shouldn't you get rid of that since it's no longer used?