Bug 170373 – REGRESSION(r213682): Web Inspector: Network columns don't get saved when Web Inspector is closed

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Steps:
1. Open Network tab.
2. Right click on one of the column headers, such as Domain.
3. Uncheck Domain to hide it.
4. Close Web Inspector.
5. Open Web Inspector.

Expected:
Domain column stays hidden.

Actual:
Domain column is visible. No matter what changes in column visibility were made, they don't get saved.

[Radar WebKit Bug Importer]

<rdar://problem/31386336>

[Joseph Pecoraro]

I don't think this was ever working.

[Joseph Pecoraro]

Created attachment 307307 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

NVI corrects me, this was working in the past.

In that case, this would have regressed with:
<https://trac.webkit.org/r213682>

Which made it possible to save the hidden/visible state of default hidden columns. It didn't work for default visible columns because `columnInfo.hidden` was undefined.

[Nikita Vasilyev]

Comment on attachment 307307 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=307307&action=review

Looks good to me.

> Source/WebInspectorUI/ChangeLog:14
> +        we always get an explicit boolean.

This is indeed what was happening.

[Matt Baker]

Comment on attachment 307307 [details]
[PATCH] Proposed Fix

r=me. I think eventually it would be nice to have a DataGridColumn object that sanitizes these types of settings.

[WebKit Commit Bot]

Comment on attachment 307307 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 307307

Committed r215449: <http://trac.webkit.org/changeset/215449>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.