Bug 170357 - Fix memory leak in CreateSessionDescriptionObserver::OnSuccess
Summary: Fix memory leak in CreateSessionDescriptionObserver::OnSuccess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-31 13:44 PDT by youenn fablet
Modified: 2017-04-11 21:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2017-03-31 13:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.90 KB, patch)
2017-04-03 09:31 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-03-31 13:44:23 PDT 
Passed raw pointer should be released.
Comment 1 youenn fablet 2017-03-31 13:45:36 PDT 
Created attachment 306007 [details]
Patch
Comment 2 Geoffrey Garen 2017-03-31 14:56:17 PDT 
Comment on attachment 306007 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-03-31 15:05:25 PDT 
Comment on attachment 306007 [details]
Patch

Clearing flags on attachment: 306007

Committed r214689: <http://trac.webkit.org/changeset/214689>
Comment 4 WebKit Commit Bot 2017-03-31 15:05:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2017-03-31 16:35:45 PDT 
This change caused a lot of crashes, rolling back.

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r214689%20(330)/results.html
Comment 6 Alexey Proskuryakov 2017-03-31 16:59:35 PDT 
Rolled back in r214700.
Comment 7 youenn fablet 2017-03-31 17:16:18 PDT 
Ah right, I should have updated libwebrtc mock. Will reland with mick updated
Comment 8 youenn fablet 2017-04-03 08:41:26 PDT 
Reopening to fix mock
Comment 9 youenn fablet 2017-04-03 09:31:31 PDT 
Created attachment 306077 [details]
Patch