Bug 170338 – Modern media controls should never be enabled in non cocoa ports

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

It's currently enabled, because it uses the default value for all other runtime features, but modern media controls are not a cross-platform feature. I think this is why media/video-click-dblckick-standalone.html started to fail after r214426. I can't reproduce the failure locally, though.

[Carlos Garcia Campos]

Created attachment 305967 [details]
Patch

[Michael Catanzaro]

Comment on attachment 305967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305967&action=review

This needs a build flag too. Having only a runtime flag really only makes sense if the feature could plausibly work on all platforms. This one is Mac-only.

And please name it with _ENABLED.

> Source/WebKit2/Shared/WebPreferencesDefinitions.h:320
> +#define DEFAULT_MODERN_MEDIA_CONTROLS true

DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED

> Source/WebKit2/Shared/WebPreferencesDefinitions.h:322
> +#define DEFAULT_MODERN_MEDIA_CONTROLS false

DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 305967 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305967&action=review
> 
> This needs a build flag too. Having only a runtime flag really only makes
> sense if the feature could plausibly work on all platforms. This one is
> Mac-only.
> 
> And please name it with _ENABLED.

Indeed. That was my intention, but somehow I didn't add that in the end.

> > Source/WebKit2/Shared/WebPreferencesDefinitions.h:320
> > +#define DEFAULT_MODERN_MEDIA_CONTROLS true
> 
> DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED
> 
> > Source/WebKit2/Shared/WebPreferencesDefinitions.h:322
> > +#define DEFAULT_MODERN_MEDIA_CONTROLS false
> 
> DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED

[Carlos Garcia Campos]

Committed r214666: <http://trac.webkit.org/changeset/214666>