Bug 170328 – [WK2] Tapping away to dismiss the selection does not update the selected DOM range using character granularity

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

<rdar://problem/30904558>

[Wenson Hsieh]

Created attachment 306008 [details]
Patch

[Wenson Hsieh]

Created attachment 306014 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 306014 [details]
Patch for landing

Clearing flags on attachment: 306014

Committed r214692: <http://trac.webkit.org/changeset/214692>

Comment on attachment 306014 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=306014&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2982
> +    if (_webView.configuration.selectionGranularity != WKSelectionGranularityCharacter)
> +        return;
> +

Why is this dependent on the selection granularity rather than the kind of selection assistant we are currently using. In other words, why does this bug (and fix) not apply to contenteditable elements in web views that don’t opt into character granularity?

[Wenson Hsieh]

(In reply to [e-mail] from comment #4)
> Comment on attachment 306014 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306014&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2982
> > +    if (_webView.configuration.selectionGranularity != WKSelectionGranularityCharacter)
> > +        return;
> > +
> 
> Why is this dependent on the selection granularity rather than the kind of
> selection assistant we are currently using. In other words, why does this
> bug (and fix) not apply to contenteditable elements in web views that don’t
> opt into character granularity?

Good point. This handling should apply when using the text interaction assistant rather than when using selectionGranularity WKSelectionGranularityCharacter. I'll fix this in a followup patch.

[Wenson Hsieh]

Created attachment 306024 [details]
Address post-review feedback

[Wenson Hsieh]

Landed followup: <http://trac.webkit.org/changeset/214696>