Bug 170315 - Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
Summary: Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWeb...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-30 17:14 PDT by Sam Weinig
Modified: 2017-03-30 17:45 PDT (History)
1 user (show)

See Also:

Attachments
Patch (9.49 KB, patch)
2017-03-30 17:16 PDT, Sam Weinig 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-03-30 17:14:20 PDT 
Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
Comment 1 Sam Weinig 2017-03-30 17:16:48 PDT 
<rdar://problem/31350588>
Comment 2 Sam Weinig 2017-03-30 17:16:54 PDT 
Created attachment 305930 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-03-30 17:35:15 PDT 
Comment on attachment 305930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305930&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:5033
> +    auto copiedCompletionHandler = Block_copy(completionHandler);

Should this use makeBlockPtr?
Comment 4 Sam Weinig 2017-03-30 17:45:08 PDT 
Committed r214643: <http://trac.webkit.org/changeset/214643>