Bug 170297 - YouTube sometimes does not respect "user gesture" restriction for videos
Summary: YouTube sometimes does not respect "user gesture" restriction for videos
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Rajca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-30 13:15 PDT by Matt Rajca
Modified: 2017-03-30 16:37 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2017-03-30 13:21 PDT, Matt Rajca 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2017-03-30 13:15:38 PDT 
I discovered a code path in WebKit that does not honor the “user gesture” requirement even though we have a restriction in place. This occurs on YouTube, which happens to use Media Streams.

<rdar://problem/31137640>
Comment 1 Matt Rajca 2017-03-30 13:21:54 PDT 
Created attachment 305889 [details]
Patch
Comment 2 Eric Carlson 2017-03-30 13:32:22 PDT 
Comment on attachment 305889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305889&action=review

As discussed over IRC, you should be able to make a layout test for this.

> Source/WebCore/ChangeLog:7
> +        even though we have a restriction in place. When using Media Streams, which YouTube does, we transition

I think you mean "MSE", not "Media Streams".
Comment 3 Matt Rajca 2017-03-30 16:32:16 PDT 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 305889 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305889&action=review
> 
> As discussed over IRC, you should be able to make a layout test for this.

Will do.

> 
> > Source/WebCore/ChangeLog:7
> > +        even though we have a restriction in place. When using Media Streams, which YouTube does, we transition
> 
> I think you mean "MSE", not "Media Streams".

Yup, updated the ChangeLog.