Bug 170293 - Small pixel differences in vertical-lr mode compared to horizontal mode
Summary: Small pixel differences in vertical-lr mode compared to horizontal mode
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-30 12:40 PDT by Javier Fernandez
Modified: 2018-11-16 06:56 PST (History)
10 users (show)

See Also:


Attachments
Patch (7.03 KB, patch)
2017-03-30 12:40 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.02 MB, application/zip)
2017-03-30 13:21 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (1012.08 KB, application/zip)
2017-03-30 13:52 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.71 MB, application/zip)
2017-03-30 13:59 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.08 MB, application/zip)
2017-03-30 14:04 PDT, Build Bot
no flags Details
Patch (7.02 KB, patch)
2018-01-12 04:58 PST, Javier Fernandez
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.25 MB, application/zip)
2018-01-12 05:57 PST, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.60 MB, application/zip)
2018-01-12 06:03 PST, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.17 MB, application/zip)
2018-01-12 06:28 PST, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-sierra (2.96 MB, application/zip)
2018-01-12 06:29 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2017-03-30 12:40:39 PDT
Vertical-lr mode rendering is not equivalent to horizontal mode
Comment 1 Javier Fernandez 2017-03-30 12:40:58 PDT
Created attachment 305874 [details]
Patch
Comment 2 Build Bot 2017-03-30 13:21:25 PDT
Comment on attachment 305874 [details]
Patch

Attachment 305874 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3442279

New failing tests:
fast/table/vertical-mode-equivalent-to-horizontal.html
fast/inline-block/vertical-mode-equivalent-to-horizontal.html
Comment 3 Build Bot 2017-03-30 13:21:26 PDT
Created attachment 305888 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-03-30 13:52:42 PDT
Comment on attachment 305874 [details]
Patch

Attachment 305874 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3442351

New failing tests:
fast/table/vertical-mode-equivalent-to-horizontal.html
fast/inline-block/vertical-mode-equivalent-to-horizontal.html
Comment 5 Build Bot 2017-03-30 13:52:44 PDT
Created attachment 305898 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-03-30 13:59:35 PDT
Comment on attachment 305874 [details]
Patch

Attachment 305874 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3442533

New failing tests:
fast/table/vertical-mode-equivalent-to-horizontal.html
fast/inline-block/vertical-mode-equivalent-to-horizontal.html
Comment 7 Build Bot 2017-03-30 13:59:36 PDT
Created attachment 305899 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-03-30 14:04:47 PDT
Comment on attachment 305874 [details]
Patch

Attachment 305874 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3442598

New failing tests:
fast/table/vertical-mode-equivalent-to-horizontal.html
fast/inline-block/vertical-mode-equivalent-to-horizontal.html
Comment 9 Build Bot 2017-03-30 14:04:48 PDT
Created attachment 305900 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 10 Simon Fraser (smfr) 2017-06-20 10:52:05 PDT
Can you provide some more explanation of what you're trying to do here?
Comment 11 Javier Fernandez 2017-06-20 14:09:47 PDT
(In reply to Simon Fraser (smfr) from comment #10)
> Can you provide some more explanation of what you're trying to do here?

Well, I just wanted to report the issue. I implemented some reference layout tests for the grid layout Baseline Alignment feature that are based on inline-blocks. However, there are tiny pixel differences in some case when combining different writing modes.

The patch just adds some simplified cases that should, IMHO, be rendered identically, but as the bots shown there are some differences. This issue is also reproducible in Blink, but only in Mac platform.
Comment 12 Javier Fernandez 2018-01-12 04:58:05 PST
Created attachment 331192 [details]
Patch
Comment 13 Build Bot 2018-01-12 05:57:11 PST
Comment on attachment 331192 [details]
Patch

Attachment 331192 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6048938

New failing tests:
fast/table/vertical-mode-equivalent-to-horizontal.html
fast/inline-block/vertical-mode-equivalent-to-horizontal.html
Comment 14 Build Bot 2018-01-12 05:57:12 PST
Created attachment 331193 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 15 Build Bot 2018-01-12 06:03:18 PST
Comment on attachment 331192 [details]
Patch

Attachment 331192 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6048956

New failing tests:
fast/table/vertical-mode-equivalent-to-horizontal.html
fast/inline-block/vertical-mode-equivalent-to-horizontal.html
Comment 16 Build Bot 2018-01-12 06:03:20 PST
Created attachment 331194 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 17 Build Bot 2018-01-12 06:28:44 PST
Comment on attachment 331192 [details]
Patch

Attachment 331192 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6048975

New failing tests:
fast/table/vertical-mode-equivalent-to-horizontal.html
fast/inline-block/vertical-mode-equivalent-to-horizontal.html
Comment 18 Build Bot 2018-01-12 06:28:46 PST
Created attachment 331196 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 19 Build Bot 2018-01-12 06:29:29 PST
Comment on attachment 331192 [details]
Patch

Attachment 331192 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6048976

New failing tests:
fast/table/vertical-mode-equivalent-to-horizontal.html
fast/inline-block/vertical-mode-equivalent-to-horizontal.html
Comment 20 Build Bot 2018-01-12 06:29:30 PST
Created attachment 331197 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6