Bug 17029 - Use of deprecated class function but declares GTK_DISABLE_DEPRECATED
Summary: Use of deprecated class function but declares GTK_DISABLE_DEPRECATED
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-27 03:44 PST by Stephan Binner
Modified: 2008-01-27 16:14 PST (History)
0 users

See Also:


Attachments
Sync bundled code with Mozilla (98.84 KB, patch)
2008-01-27 15:54 PST, Alp Toker
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Binner 2008-01-27 03:44:12 PST
> E: WebKitGtk 64bit-portability-issue ../../WebCore/platform/gtk/gtk2drawing.c: 203

gtk2drawing.c used gtk_option_menu_new() while the build system defines GTK_DISABLE_DEPRECATED, result: gtk_option_menu_new() is rather undefined.
Comment 1 Alp Toker 2008-01-27 15:54:10 PST
Created attachment 18729 [details]
Sync bundled code with Mozilla

gtkdrawing.h and gtk2drawing.c are bundled sources so no need to review them too closely
Comment 2 Alp Toker 2008-01-27 16:14:16 PST
Thanks! Fix landed in r29824.

(Just to be clear, this build error would only have showed up in debug builds. WebKit debug builds are quite different from release builds, being heavily instrumented and not suitable for deployment.)