Bug 170288 - We are spending a lot of time bzero'ing AudioChannel buffers on uni-watch.com
Summary: We are spending a lot of time bzero'ing AudioChannel buffers on uni-watch.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-30 11:55 PDT by Chris Dumez
Modified: 2017-03-30 13:46 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2017-03-30 12:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-03-30 11:55:48 PDT 
We are spending a lot of time bzero'ing AudioChannel buffers on uni-watch.com due to doubleclick ads using WebAudio with a 0-gain GainNode. We should optimize the 0-gain case as much as possible.
Comment 1 Chris Dumez 2017-03-30 11:56:01 PDT 
<rdar://problem/31289132>
Comment 2 Chris Dumez 2017-03-30 12:07:11 PDT 
Created attachment 305871 [details]
Patch
Comment 3 Chris Dumez 2017-03-30 13:46:08 PDT 
Comment on attachment 305871 [details]
Patch

Clearing flags on attachment: 305871

Committed r214620: <http://trac.webkit.org/changeset/214620>
Comment 4 Chris Dumez 2017-03-30 13:46:09 PDT 
All reviewed patches have been landed.  Closing bug.