Bug 170286 - NetworkConnectionToWebProcess should stop web sockets when being destroyed
Summary: NetworkConnectionToWebProcess should stop web sockets when being destroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-30 09:20 PDT by youenn fablet
Modified: 2017-04-05 10:56 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.24 KB, patch)
2017-03-30 09:22 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-03-30 09:20:47 PDT
If the Web Process is crashing, we should stop all web socket networking
Comment 1 youenn fablet 2017-03-30 09:22:06 PDT
Created attachment 305863 [details]
Patch
Comment 2 youenn fablet 2017-03-30 09:39:01 PDT
(In reply to youenn fablet from comment #1)
> Created attachment 305863 [details]
> Patch

I did manual testing to ensure this patch is working.
We should probably write a test for it, like a unit test which would access a web socket server.
Comment 3 Brady Eidson 2017-03-30 10:00:29 PDT
(In reply to youenn fablet from comment #2)
> (In reply to youenn fablet from comment #1)
> > Created attachment 305863 [details]
> > Patch
> 
> I did manual testing to ensure this patch is working.
> We should probably write a test for it, like a unit test which would access
> a web socket server.

We currently don't have the ability to write unit tests (e.g. API tests) that utilize HTTP.

We only have an httpd available in layout tests.
Comment 4 Brady Eidson 2017-03-30 12:39:14 PDT
Comment on attachment 305863 [details]
Patch

ALEX! I TOLD YOU TO MAKE SURE THIS DIDN'T HAPPEN!!!!!
Comment 5 WebKit Commit Bot 2017-03-30 13:09:09 PDT
Comment on attachment 305863 [details]
Patch

Clearing flags on attachment: 305863

Committed r214616: <http://trac.webkit.org/changeset/214616>
Comment 6 WebKit Commit Bot 2017-03-30 13:09:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Alex Christensen 2017-04-05 10:56:54 PDT
😳