Bug 170266 - WebAssembly: B3IRGenerator should pool constants
Summary: WebAssembly: B3IRGenerator should pool constants
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-29 19:10 PDT by Keith Miller
Modified: 2017-03-29 19:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (27.96 KB, patch)
2017-03-29 19:18 PDT, Keith Miller 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-03-29 19:10:40 PDT 
WebAssembly: B3IRGenerator should pool constants
Comment 1 Keith Miller 2017-03-29 19:18:13 PDT 
Created attachment 305820 [details]
Patch
Comment 2 Filip Pizlo 2017-03-29 19:25:26 PDT 
Comment on attachment 305820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305820&action=review

seems legit

> Source/JavaScriptCore/b3/B3Procedure.h:121
> +    // bits is a bitwise_cast of the constant you want.
> +    Value* addConstant(Origin, Type, uint64_t bits);

Nice
Comment 3 Keith Miller 2017-03-29 19:39:56 PDT 
Committed r214592: <http://trac.webkit.org/changeset/214592>