Bug 170261 – WebAssembly: Make our calls out to JS PIC friendly

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Working on this now.

[Saam Barati]

Created attachment 306034 [details]
patch

[Keith Miller]

Comment on attachment 306034 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306034&action=review

r=me.

> Source/JavaScriptCore/wasm/js/JSWebAssemblyCodeBlock.h:120
> +    static ptrdiff_t offsetOfImportWasmToJSStub(unsigned calleeCount, unsigned importIndex)
> +    {
> +        return offsetOfCallees()
> +            + (sizeof(WriteBarrier<JSWebAssemblyCallee>) * calleeCount * 2)
> +            + (sizeof(void*) * importIndex);
> +    }
> +

oh man, this is brutal.

[Saam Barati]

Comment on attachment 306034 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306034&action=review

>> Source/JavaScriptCore/wasm/js/JSWebAssemblyCodeBlock.h:120
>> +
> 
> oh man, this is brutal.

Glorious object layout 🎉

[WebKit Commit Bot]

Comment on attachment 306034 [details]
patch

Clearing flags on attachment: 306034

Committed r214711: <http://trac.webkit.org/changeset/214711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.