Bug 170255 - webkitpy: Robust test clean-up
Summary: webkitpy: Robust test clean-up
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-29 13:51 PDT by Jonathan Bedard
Modified: 2017-03-31 16:38 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.58 KB, patch)
2017-03-29 13:56 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-03-29 13:51:43 PDT 
Currently when running layouts tests, clean-up only occurs if setup has been successful.  If setup throws an exception, this can result in file or programs left running.  This is of particular concern for something like an iOS Simulator.  We should run teardown even if setup throws an exception and we should teardown all devices even if one or more of them throws an exception while being torn down.
Comment 1 Radar WebKit Bug Importer 2017-03-29 13:52:09 PDT 
<rdar://problem/31329367>
Comment 2 Jonathan Bedard 2017-03-29 13:56:44 PDT 
Created attachment 305782 [details]
Patch
Comment 3 Jonathan Bedard 2017-03-29 15:14:45 PDT 
EWS failure is unrelated to this patch and is a problem on the bot.
Comment 4 WebKit Commit Bot 2017-03-29 15:44:45 PDT 
Comment on attachment 305782 [details]
Patch

Clearing flags on attachment: 305782

Committed r214569: <http://trac.webkit.org/changeset/214569>
Comment 5 WebKit Commit Bot 2017-03-29 15:44:48 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Jonathan Bedard 2017-03-31 16:38:54 PDT 
https://trac.webkit.org/changeset/214698/webkit has a minor fix to this patch.