RESOLVED FIXED 170255
webkitpy: Robust test clean-up 
https://bugs.webkit.org/show_bug.cgi?id=170255
Summary webkitpy: Robust test clean-up
Jonathan Bedard
Reported 2017-03-29 13:51:43 PDT
Currently when running layouts tests, clean-up only occurs if setup has been successful. If setup throws an exception, this can result in file or programs left running. This is of particular concern for something like an iOS Simulator. We should run teardown even if setup throws an exception and we should teardown all devices even if one or more of them throws an exception while being torn down.
Attachments
Patch (3.58 KB, patch)
2017-03-29 13:56 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-03-29 13:52:09 PDT
<rdar://problem/31329367>
Jonathan Bedard
Comment 2 2017-03-29 13:56:44 PDT
Created attachment 305782 [details] Patch
Jonathan Bedard
Comment 3 2017-03-29 15:14:45 PDT
EWS failure is unrelated to this patch and is a problem on the bot.
WebKit Commit Bot
Comment 4 2017-03-29 15:44:45 PDT
Comment on attachment 305782 [details] Patch Clearing flags on attachment: 305782 Committed r214569: <http://trac.webkit.org/changeset/214569>
WebKit Commit Bot
Comment 5 2017-03-29 15:44:48 PDT
All reviewed patches have been landed. Closing bug.
Jonathan Bedard
Comment 6 2017-03-31 16:38:54 PDT
https://trac.webkit.org/changeset/214698/webkit has a minor fix to this patch.
Note You need to log in before you can comment on or make changes to this bug.