Bug 170244 - WebAssembly: pack OpcodeOrigin to fit in a pointer
Summary: WebAssembly: pack OpcodeOrigin to fit in a pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-29 10:08 PDT by Keith Miller
Modified: 2017-03-29 10:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.98 KB, patch)
2017-03-29 10:15 PDT, Keith Miller 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-03-29 10:08:40 PDT 
WebAssembly: pack OpcodeOrigin to fit in a pointer
Comment 1 Keith Miller 2017-03-29 10:15:09 PDT 
Created attachment 305753 [details]
Patch
Comment 2 Michael Saboff 2017-03-29 10:23:55 PDT 
Comment on attachment 305753 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305753&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        This makes it so we don't have to have different allocate the OpcodeOrigin for B3.

Think this sentence needs a little work.
Comment 3 Keith Miller 2017-03-29 10:27:30 PDT 
Committed r214544: <http://trac.webkit.org/changeset/214544>
Comment 4 Keith Miller 2017-03-29 10:29:00 PDT 
Comment on attachment 305753 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305753&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        This makes it so we don't have to have different allocate the OpcodeOrigin for B3.
> 
> Think this sentence needs a little work.

I changed it to:

This patch makes it so we don't have to have allocate OpcodeOrigins and can just pack all the data into the pointer B3::Origin already has.