Bug 170239 - [Modern Media Controls] Controls bar may disappear while captions menu is visible (redux)
Summary: [Modern Media Controls] Controls bar may disappear while captions menu is vis...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-29 07:08 PDT by Antoine Quint
Modified: 2017-03-29 10:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (14.56 KB, patch)
2017-03-29 07:15 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (14.74 KB, patch)
2017-03-29 07:20 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-03-29 07:08:19 PDT 
We did some work in https://bugs.webkit.org/show_bug.cgi?id=168751 to prevent the controls bar from disappearing while the captions menu is visible. But there were two remaining issues:

1. the controls bar would hide upon exiting the video.
2. clicking on the controls bar while the caption panel is up would hide the controls bar as well as the captions panel.
Comment 1 Radar WebKit Bug Importer 2017-03-29 07:08:38 PDT 
<rdar://problem/31320684>
Comment 2 Radar WebKit Bug Importer 2017-03-29 07:08:40 PDT 
<rdar://problem/31320685>
Comment 3 Antoine Quint 2017-03-29 07:15:34 PDT 
Created attachment 305730 [details]
Patch
Comment 4 Antoine Quint 2017-03-29 07:20:15 PDT 
Created attachment 305731 [details]
Patch
Comment 5 WebKit Commit Bot 2017-03-29 10:28:51 PDT 
Comment on attachment 305731 [details]
Patch

Clearing flags on attachment: 305731

Committed r214545: <http://trac.webkit.org/changeset/214545>
Comment 6 WebKit Commit Bot 2017-03-29 10:28:55 PDT 
All reviewed patches have been landed.  Closing bug.