Bug 170227 – WebAssembly: add shell-only Memory mode helper

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[JF Bastien]

While hacking in JSC or testing the implementation, it's useful to be able to figure out which mode a Memory or an Instance's Memory is in.

[JF Bastien]

Created attachment 305704 [details]
patch

[JF Bastien]

Created attachment 305708 [details]
patch

Missing private export.

[Keith Miller]

How do you plan to use this? I'm skeptical of writing tests that assert the memory mode they are in. It's not clear that the OS guarantees that we can get any number of Signaling memories, especially if the system is under memory pressure.

[JF Bastien]

(In reply to Keith Miller from comment #3)
> How do you plan to use this? I'm skeptical of writing tests that assert the
> memory mode they are in. It's not clear that the OS guarantees that we can
> get any number of Signaling memories, especially if the system is under
> memory pressure.

I want to run some benchmarks and see which get fast memory, which don't. When I print out runtime numbers I can bin these differently.

Of course if I get zero Signaling or zero BoundsChecked, and I expected to get some, then I'll have to do something else. This tool won't solve that issue, it'll just make it apparent.

[JF Bastien]

Created attachment 305745 [details]
patch

Also export Instance / Module s_info, which is used by jsc.cpp.

[Mark Lam]

Comment on attachment 305745 [details]
patch

r=me

[Mark Lam]

Please fix build failures before landing.

[Build Bot]

Comment on attachment 305745 [details]
patch

Attachment 305745 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/3434349

New failing tests:
wasm.yaml/wasm/js-api/element.js.default-wasm
wasm.yaml/wasm/js-api/test_memory.js.default-wasm
wasm.yaml/wasm/function-tests/memory-section-and-import.js.default-wasm

[JF Bastien]

Created attachment 305756 [details]
patch

The fix in assert.js un-hid actual failures in other tests, which I now fixed. They were just trying to match error strings which changed.

[WebKit Commit Bot]

Comment on attachment 305756 [details]
patch

Clearing flags on attachment: 305756

Committed r214547: <http://trac.webkit.org/changeset/214547>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.