AssemblyHelpers should not have a VM field

[Saam Barati]

APIs that need VM, should take one as a parameter. When doing PIC for wasm, we don't want to tie code generation to a VM.

[Saam Barati]

Created attachment 305656 [details]
patch

[Saam Barati]

Comment on attachment 305656 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305656&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        independent code for Wasm, we can't want to tie code generation to a VM.

will fix typo locally.

[Build Bot]

Attachment 305656 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/AssemblyHelpers.h:1546:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Comment on attachment 305656 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305656&action=review

r=me with comments.

> Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp:-50
> -    

Why is this dropped?

> Source/JavaScriptCore/dfg/DFGOSRExitCompiler64.cpp:-54
> -    

Ditto.

> Source/JavaScriptCore/ftl/FTLThunks.cpp:169
> +    AssemblyHelpers jit(0);

Let's use nullptr.

> Source/JavaScriptCore/jit/AssemblyHelpers.h:-977
> -    void debugCall(V_DebugOperation_EPP function, void* argument)

Why is this utility dropped? I think it is still useful (And I think moving it to cpp file is better).

[Saam Barati]

Comment on attachment 305656 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305656&action=review

>> Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp:-50
>> -    
> 
> Why is this dropped?

I think we should just use probes.

[Saam Barati]

Comment on attachment 305656 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305656&action=review

>>> Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp:-50
>>> -    
>> 
>> Why is this dropped?
> 
> I think we should just use probes.

I'll just keep this utility function for now.

[Saam Barati]

Created attachment 305660 [details]
patch for landing

If all platforms build.

[Build Bot]

Attachment 305660 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/AssemblyHelpers.h:1550:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Created attachment 305664 [details]
patch for landing

[Build Bot]

Attachment 305664 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/AssemblyHelpers.h:1551:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Created attachment 305666 [details]
patch for landing

Trying to fix 32-bit build issues.

[Build Bot]

Attachment 305666 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/AssemblyHelpers.h:1551:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Created attachment 305672 [details]
patch for landing

I think 32-bit builds now.

[Build Bot]

Attachment 305672 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/AssemblyHelpers.h:1551:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 305672 [details]
patch for landing

Attachment 305672 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3430388

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 305688 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Saam Barati]

Created attachment 305699 [details]
patch for landing

Fixed the crash. It was from accidentally capturing |this| inside a lambda in FTLLower

[Build Bot]

Attachment 305699 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jit/AssemblyHelpers.h:1551:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 305699 [details]
patch for landing

Clearing flags on attachment: 305699

Committed r214531: <http://trac.webkit.org/changeset/214531>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.