Bug 170206 – webkitpy: Add IOSDevicePort and IOSPort tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

We only have unit tests for IOSSimulatorPort.  Add unit tests for IOSDevicePort and IOSPort.

[Radar WebKit Bug Importer]

<rdar://problem/31308364>

[Jonathan Bedard]

Created attachment 305647 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 305647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305647&action=review

r=me, please fix class naming.

> Tools/Scripts/webkitpy/port/ios_device_unittest.py:27
> +class iosDeviceTest(ios_testcase.iOSTest):

Although there is one test class named like this, the WebKit style calls for "IOSDeviceTest" as the name. Most iOS classes in webkitpy follow the style.

> Tools/Scripts/webkitpy/port/ios_device_unittest.py:28
> +    os_name = 'ios-device'

This shows a shortcoming in the code - the OS name is iOS, not iOS Device.

> Tools/Scripts/webkitpy/port/ios_device_unittest.py:31
> +    port_maker = IOSDevicePort

Maker is a strange name, there is no pattern like this that I'm aware of.

> Tools/Scripts/webkitpy/port/ios_device_unittest.py:32
> +    is_simulator = True

Wut?

> Tools/Scripts/webkitpy/port/ios_device_unittest.py:36
> +        port.set_option('child_processes', 1)

This is worth explaining if it's needed (is it?)

> Tools/Scripts/webkitpy/port/ios_simulator_unittest.py:32
> +class iosSimulatorTest(ios_testcase.iOSTest):

Ditto w.r.t. naming.

[Jonathan Bedard]

Created attachment 305735 [details]
Patch

[Jonathan Bedard]

Created attachment 305752 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 305752 [details]
Patch for landing

Clearing flags on attachment: 305752

Committed r214542: <http://trac.webkit.org/changeset/214542>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.