LayoutTest media/track/track-cue-rendering-with-padding.html is a flaky timeout https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/198 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Ftrack-cue-rendering-with-padding.html
No timeouts from 2017-3-5 till 2017-3-16; one on 2017-3-16; frequent timeouts starting 2017-3-27.
Created attachment 305841 [details] Patch
Comment on attachment 305841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305841&action=review > LayoutTests/media/track/track-cue-rendering-with-padding.html:20 > + var maxRetries = 256; This means the test won't fail for 25 seconds. What made you choose such a long time, it seems *extremely* unlikely that it could take that long for the cue display element to be created.
(In reply to Eric Carlson from comment #3) > Comment on attachment 305841 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305841&action=review > > > LayoutTests/media/track/track-cue-rendering-with-padding.html:20 > > + var maxRetries = 256; > > This means the test won't fail for 25 seconds. What made you choose such a > long time, it seems *extremely* unlikely that it could take that long for > the cue display element to be created. I chose a long time in order to make sure that if the test fails again, it was definitely not because we picked a too short time. But 25 seconds is probably a little too long, though :)
Comment on attachment 305841 [details] Patch Thanks for reviewing!
FWIW, 20 to 25 seconds is what I'd have picked too. The delays can be huge sometimes (think of 18 media tests running with GuardMalloc in parallel, and a couple of them crashing).
Comment on attachment 305841 [details] Patch Rejecting attachment 305841 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 305841, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/media/track/track-cue-rendering-with-padding.html Hunk #1 FAILED at 16. Hunk #2 FAILED at 26. 2 out of 2 hunks FAILED -- saving rejects to file LayoutTests/media/track/track-cue-rendering-with-padding.html.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3442599
Committed <https://trac.webkit.org/changeset/214612/webkit>.