Bug 170173 – [OWR] Fix class structure for the OWR mock classes after last modifications

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alejandro G. Castro]

In case of OWR MockRealtimeMediaSource.h inherits from RealtimeMediaSourceOwr, so we have to change some of the definitions.

[Alejandro G. Castro]

Created attachment 305581 [details]
Patch

[youenn fablet]

Comment on attachment 305581 [details]
Patch

To make things cleaner, the mock owr source could just implement RealtimeMediaSource and forwards calls to a member field inheriting from RealtimeMediaSourceOwr. Future refactoring?

View in context: https://bugs.webkit.org/attachment.cgi?id=305581&action=review

> Source/WebCore/platform/mock/MockRealtimeMediaSource.h:64
> +#if !USE(OPENWEBRTC)

Or you could add a noop implementation here or in mock owr subclasses

[Alejandro G. Castro]

Thanks for the review!

(In reply to youenn fablet from comment #2)
> Comment on attachment 305581 [details]
> Patch
> 
> To make things cleaner, the mock owr source could just implement
> RealtimeMediaSource and forwards calls to a member field inheriting from
> RealtimeMediaSourceOwr. Future refactoring?
> 

Yeah, we want to review the whole mock class for webrtc at some point.

> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305581&action=review
> 
> > Source/WebCore/platform/mock/MockRealtimeMediaSource.h:64
> > +#if !USE(OPENWEBRTC)
> 
> Or you could add a noop implementation here or in mock owr subclasses

Actually the OWR is a super class of Mock, it is a noop already there, I would need to override in that case and don't do it for other platforms.

[WebKit Commit Bot]

Comment on attachment 305581 [details]
Patch

Clearing flags on attachment: 305581

Committed r214772: <http://trac.webkit.org/changeset/214772>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.