Bug 170166 – Stop RTCDataChannel when closing page

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

One possibility is to make RTCDataChannel an ActiveDOMObject.

[youenn fablet]

Created attachment 305560 [details]
Patch

[youenn fablet]

Created attachment 305597 [details]
Patch

[Eric Carlson]

Comment on attachment 305597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305597&action=review

> Source/WebCore/Modules/mediastream/RTCDataChannel.h:93
> +    bool canSuspendForDocumentSuspension() const final { return false; }

It seems this should at least return true when readyState is ReadyStateClosed.

[youenn fablet]

Created attachment 305613 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

(In reply to Eric Carlson from comment #3)
> Comment on attachment 305597 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305597&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCDataChannel.h:93
> > +    bool canSuspendForDocumentSuspension() const final { return false; }
> 
> It seems this should at least return true when readyState is
> ReadyStateClosed.

Indeed!

[WebKit Commit Bot]

Comment on attachment 305613 [details]
Patch for landing

Clearing flags on attachment: 305613

Committed r214485: <http://trac.webkit.org/changeset/214485>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

(In reply to WebKit Commit Bot from comment #6)
> Comment on attachment 305613 [details]
> Patch for landing
> 
> Clearing flags on attachment: 305613
> 
> Committed r214485: <http://trac.webkit.org/changeset/214485>

This change appears to have caused LayoutTest crashes:

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r214485%20(177)/results.html

[Ryan Haddad]

Reverted r214485 for reason:

This change caused LayoutTest crashes.

Committed r214500: <http://trac.webkit.org/changeset/214500>

[youenn fablet]

Created attachment 305663 [details]
Patch for landing

[youenn fablet]

(In reply to youenn fablet from comment #10)
> Created attachment 305663 [details]
> Patch for landing

Added the missing call to suspendIfNeeded.

[WebKit Commit Bot]

Comment on attachment 305663 [details]
Patch for landing

Clearing flags on attachment: 305663

Committed r214508: <http://trac.webkit.org/changeset/214508>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.