170152 – REGRESSION: getComputedStyle LayoutTests are flaky

Bug 170152 - REGRESSION: getComputedStyle LayoutTests are flaky

Summary: REGRESSION: getComputedStyle LayoutTests are flaky

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-03-27 18:02 PDT by Ryan Haddad
Modified:	2017-03-29 09:54 PDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ryan Haddad 2017-03-27 18:02:41 PDT

REGRESSION: getComputedStyle LayoutTests are flaky

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=svg%2Fcss%2FgetComputedStyle-basic.xhtml
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcss%2FgetComputedStyle%2Fcomputed-style.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcss%2FgetComputedStyle%2Fcomputed-style-font-family.html

Comment 1 Ryan Haddad 2017-03-27 18:04:17 PDT

The tree is locked at the moment, so we can't roll out or make any changes. 

Myles said he will look at this tonight and if he can't find a solution, we can roll out the change.

Comment 2 Ryan Haddad 2017-03-27 18:04:44 PDT

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcss%2FgetComputedStyle%2Fcomputed-style-without-renderer.html

Comment 3 Myles C. Maxfield 2017-03-28 01:24:22 PDT

I think I fixed this in https://trac.webkit.org/changeset/214467/webkit

Comment 4 Ryan Haddad 2017-03-29 09:54:01 PDT

(In reply to Myles C. Maxfield from comment #3)
> I think I fixed this in https://trac.webkit.org/changeset/214467/webkit

Looks like that worked. Thanks!