Bug 170148 - LayoutTest webrtc/video-getParameters.html is failing
Summary: LayoutTest webrtc/video-getParameters.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-27 17:31 PDT by Ryan Haddad
Modified: 2017-09-27 12:55 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.27 KB, patch)
2017-03-28 08:30 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (2.76 KB, patch)
2017-09-18 13:52 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-03-27 17:31:06 PDT
LayoutTest webrtc/video-getParameters.html is failing

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r214437%20(205)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fvideo-getParameters.html

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/webrtc/video-getParameters-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/webrtc/video-getParameters-actual.txt
@@ -1,3 +1,3 @@
 
-PASS Basic video stats 
+FAIL Basic video stats assert_equals: testing sender vs. receiver parameters expected "{\"codecs\":[],\"degradationPreference\":\"balanced\",\"encodings\":[{\"active\":true,\"dtx\":\"disabled\",\"fec\":{\"ssrc\":57},\"maxBitrate\":0,\"maxFramerate\":0,\"priority\":\"medium\",\"rid\":\"\",\"rtx\":{\"ssrc\":1324972544},\"scaleResolutionDownBy\":1,\"ssrc\":1191579376}],\"headerExtensions\":[],\"transactionId\":\"\"}" but got "{\"codecs\":[],\"degradationPreference\":\"balanced\",\"encodings\":[{\"active\":true,\"dtx\":\"disabled\",\"fec\":{\"ssrc\":81},\"maxBitrate\":0,\"maxFramerate\":0,\"priority\":\"medium\",\"rid\":\"\",\"rtx\":{\"ssrc\":1335299240},\"scaleResolutionDownBy\":1,\"ssrc\":1191579376}],\"headerExtensions\":[],\"transactionId\":\"\"}"
Comment 1 youenn fablet 2017-03-28 08:30:12 PDT
Created attachment 305594 [details]
Patch
Comment 2 WebKit Commit Bot 2017-03-28 09:12:45 PDT
Comment on attachment 305594 [details]
Patch

Clearing flags on attachment: 305594

Committed r214477: <http://trac.webkit.org/changeset/214477>
Comment 3 WebKit Commit Bot 2017-03-28 09:12:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 youenn fablet 2017-03-28 09:14:19 PDT
Need to fix the test appropriately
Comment 5 youenn fablet 2017-09-18 13:52:30 PDT
Created attachment 321126 [details]
Patch
Comment 6 WebKit Commit Bot 2017-09-19 08:51:53 PDT
Comment on attachment 321126 [details]
Patch

Clearing flags on attachment: 321126

Committed r222207: <http://trac.webkit.org/changeset/222207>
Comment 7 WebKit Commit Bot 2017-09-19 08:51:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:55:51 PDT
<rdar://problem/34694293>