Bug 170143 - Web Inspector: Probe values not showing in sidebar
Summary: Web Inspector: Probe values not showing in sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-27 15:05 PDT by Joseph Pecoraro
Modified: 2017-04-05 13:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2017-04-05 13:00 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-03-27 15:05:01 PDT 
Summary:
Probe values not showing in sidebar

Steps to Reproduce:
1. Inspect http://bogojoker.com/shell/
2. Resources > Select easySlider.min.js
3. Add a breakpoint on line 56
4. Right click > Edit Breakpoint
5. Add Action
6. Add a Probe Expression: "autoplay"
7. Automatically continue after evaluating
8. Dismiss popover
  => Should now have a Probes sidebar
9. Click the down arrow on the page
  => Should log a value in the Probe Datagrid, but nothing shows
Comment 1 Devin Rousso 2017-03-27 16:11:42 PDT 
I think this is being caused by the way WebInspector.ProbeSetDataGrid is being used by WebInspector.ProbeSetDetailsSection.  Since WebInspector.DetailsSection is not yet a subclass of WebInspector.View, the check for `_isAttachedToRoot` fails as it's not a subview of the root, instead being added manually by calling `appendChild` on the actual element.
Comment 2 Matt Baker 2017-04-05 13:00:05 PDT 
Created attachment 306304 [details]
Patch
Comment 3 Joseph Pecoraro 2017-04-05 13:46:51 PDT 
Comment on attachment 306304 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-04-05 13:58:54 PDT 
Comment on attachment 306304 [details]
Patch

Clearing flags on attachment: 306304

Committed r214967: <http://trac.webkit.org/changeset/214967>
Comment 5 WebKit Commit Bot 2017-04-05 13:58:55 PDT 
All reviewed patches have been landed.  Closing bug.