Bug 170139 – Add some missing NetworkResourceLoader logging

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Keith Rollin]

Execution can enter the lambda in NetworkResourceLoader::retrieveCacheEntry, without there being much indication of which exit point was taken. If flow enters into startNetworkLoad, we'll get some logging from that function, but not from the others. Add some logging so that we know what the result was from looking up the resource in the cache.

Having this logging would have helped in the tracking down of situations where we see in the logs that a resource is starting to be loaded but then there's no logging saying what ultimately happened to it.

[Keith Rollin]

Created attachment 305507 [details]
Patch

[Alex Christensen]

Comment on attachment 305507 [details]
Patch

More logs.  r=me.
I think it's unnecessary to add a new function for this.

[Keith Rollin]

Created attachment 306848 [details]
Patch

[Build Bot]

Comment on attachment 306848 [details]
Patch

Attachment 306848 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3519196

New failing tests:
webrtc/negotiatedneeded-event-addStream.html

[Build Bot]

Created attachment 306863 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Keith Rollin]

Created attachment 306931 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 306931 [details]
Patch

Clearing flags on attachment: 306931

Committed r215294: <http://trac.webkit.org/changeset/215294>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.