Bug 170139 - Add some missing NetworkResourceLoader logging
Summary: Add some missing NetworkResourceLoader logging
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Depends on:
Reported: 2017-03-27 13:55 PDT by Keith Rollin
Modified: 2017-04-12 14:46 PDT (History)
5 users (show)

See Also:

Patch (6.04 KB, patch)
2017-03-27 14:19 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (4.22 KB, patch)
2017-04-11 14:01 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (913.23 KB, application/zip)
2017-04-11 15:19 PDT, Build Bot
no flags Details
Patch (4.22 KB, patch)
2017-04-12 13:24 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2017-03-27 13:55:46 PDT
Execution can enter the lambda in NetworkResourceLoader::retrieveCacheEntry, without there being much indication of which exit point was taken. If flow enters into startNetworkLoad, we'll get some logging from that function, but not from the others. Add some logging so that we know what the result was from looking up the resource in the cache.

Having this logging would have helped in the tracking down of situations where we see in the logs that a resource is starting to be loaded but then there's no logging saying what ultimately happened to it.
Comment 1 Keith Rollin 2017-03-27 14:19:49 PDT
Created attachment 305507 [details]
Comment 2 Alex Christensen 2017-04-05 06:55:08 PDT
Comment on attachment 305507 [details]

More logs.  r=me.
I think it's unnecessary to add a new function for this.
Comment 3 Keith Rollin 2017-04-11 14:01:56 PDT
Created attachment 306848 [details]
Comment 4 Build Bot 2017-04-11 15:19:08 PDT
Comment on attachment 306848 [details]

Attachment 306848 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3519196

New failing tests:
Comment 5 Build Bot 2017-04-11 15:19:09 PDT
Created attachment 306863 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Keith Rollin 2017-04-12 13:24:12 PDT
Created attachment 306931 [details]
Comment 7 WebKit Commit Bot 2017-04-12 14:46:13 PDT
Comment on attachment 306931 [details]

Clearing flags on attachment: 306931

Committed r215294: <http://trac.webkit.org/changeset/215294>
Comment 8 WebKit Commit Bot 2017-04-12 14:46:14 PDT
All reviewed patches have been landed.  Closing bug.