RESOLVED FIXED Bug 170121
webkitpy: Use host pattern for devices 
https://bugs.webkit.org/show_bug.cgi?id=170121
Summary webkitpy: Use host pattern for devices
Jonathan Bedard
Reported 2017-03-27 10:49:49 PDT
To maximize code re-use, devices should have all of the same qualities as a host object, allowing devices to be passed to functions expecting a host.
Attachments
Patch (6.11 KB, patch)
2017-03-27 10:51 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.82 KB, patch)
2017-03-27 15:03 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2017-03-27 10:51:16 PDT
Created attachment 305484 [details] Patch
Radar WebKit Bug Importer
Comment 2 2017-03-27 10:51:29 PDT
<rdar://problem/31277095>
Daniel Bates
Comment 3 2017-03-27 14:20:29 PDT
Comment on attachment 305484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305484&action=review > Tools/ChangeLog:9 > + throughout webkitpy. Add the needed properties and This sentence does not read well. > Tools/Scripts/webkitpy/port/device.py:36 > + try: Is it necessary to use a try-catch? I do not see the harm in having a Python exception thrown if this property does not exist in the platform device. Such an exception would tell us either that we need to implement this functionality or that the caller must conditionalize the call to this property. > Tools/Scripts/webkitpy/port/device.py:43 > + try: Ditto. > Tools/Scripts/webkitpy/port/device.py:50 > + try: Ditto > Tools/Scripts/webkitpy/port/device.py:57 > + try: Ditto. > Tools/Scripts/webkitpy/port/device.py:64 > + try: Ditto.
Jonathan Bedard
Comment 4 2017-03-27 15:03:42 PDT
Created attachment 305516 [details] Patch
WebKit Commit Bot
Comment 5 2017-03-28 07:06:53 PDT
Comment on attachment 305516 [details] Patch Clearing flags on attachment: 305516 Committed r214473: <http://trac.webkit.org/changeset/214473>
WebKit Commit Bot
Comment 6 2017-03-28 07:06:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.