Bug 170116 – Fixes for libwebrtc logging after r214288

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alejandro G. Castro]

The refactor of g_log_crit was not complete after that commit.

[Alejandro G. Castro]

Created attachment 305462 [details]
Patch

[Alejandro G. Castro]

Created attachment 305463 [details]
Patch

[youenn fablet]

Comment on attachment 305463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305463&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/base/logging.cc:121
> +    static webrtc::NeverDestroyed<LogMessage::StreamList> streams GUARDED_BY(g_log_crit());

Why do we need both changes in this method?

[Alejandro G. Castro]

(In reply to youenn fablet from comment #3)
> Comment on attachment 305463 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305463&action=review
> 
> > Source/ThirdParty/libwebrtc/Source/webrtc/base/logging.cc:121
> > +    static webrtc::NeverDestroyed<LogMessage::StreamList> streams GUARDED_BY(g_log_crit());
> 
> Why do we need both changes in this method?

First one to use the method g_log_crit() instead of the old variable g_log_crit when creating the static variable, and the second change to make sure everyone calling the method does it inside a critical section because it is returning the guarded variable, clang is complaining to us if we don't do it.

[WebKit Commit Bot]

Comment on attachment 305463 [details]
Patch

Clearing flags on attachment: 305463

Committed r214466: <http://trac.webkit.org/changeset/214466>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.