Bug 170115 - [GTK] NetscapePluginX11::m_windowID is unused/unneeded
Summary: [GTK] NetscapePluginX11::m_windowID is unused/unneeded
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
Depends on:
Reported: 2017-03-27 03:49 PDT by Adrian Perez
Modified: 2017-03-27 06:38 PDT (History)
7 users (show)

See Also:

Patch (2.37 KB, patch)
2017-03-27 03:54 PDT, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-03-27 03:49:21 PDT
Building WebKitGTK+ with Clang produces the following warning:

  Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:67:14: warning: private field 'm_windowID' is not used [-Wunused-private-field]
      uint64_t m_windowID { 0 };

The “windowID” parameter is still needed in the constructor, as it gets
passed to “gtk_plug_new()”, but that is the only use.

I'll be sending a patch to remove the unneeded “m_windowID” member.
Comment 1 Adrian Perez 2017-03-27 03:54:57 PDT
Created attachment 305461 [details]
Comment 2 Adrian Perez 2017-03-27 05:02:36 PDT
JFTR, the failures in the Windows/Mac EWSs seem completely unrelated.
(Also: the lines changed are guarded with “PLATFORM(GTK)”)
Comment 3 WebKit Commit Bot 2017-03-27 06:38:38 PDT
Comment on attachment 305461 [details]

Clearing flags on attachment: 305461

Committed r214412: <http://trac.webkit.org/changeset/214412>
Comment 4 WebKit Commit Bot 2017-03-27 06:38:41 PDT
All reviewed patches have been landed.  Closing bug.