WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
170104
REGRESSION (
r214354
): Web Inspector: WebSocket connection icon obscures close content view icon
https://bugs.webkit.org/show_bug.cgi?id=170104
Summary
REGRESSION (r214354): Web Inspector: WebSocket connection icon obscures close...
Nikita Vasilyev
Reported
2017-03-25 19:50:03 PDT
Created
attachment 305412
[details]
[Image] Bug Regressed when this icon was introduced. I still like the Matt's idea of indicating the connection status by replacing or perhaps augmenting the document icon.
Attachments
[Image] Bug
(48.11 KB, image/png)
2017-03-25 19:50 PDT
,
Nikita Vasilyev
no flags
Details
Patch
(6.00 KB, patch)
2017-03-27 14:52 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2017-03-27 14:52:53 PDT
Created
attachment 305513
[details]
Patch
Devin Rousso
Comment 2
2017-03-27 14:53:44 PDT
(In reply to Devin Rousso from
comment #1
)
> Created
attachment 305513
[details]
> Patch
This patch removes any indicator from the Network tab. I feel this is fine since there is more information (such as the increasing size or the waterfall) that a Socket is still alive.
Matt Baker
Comment 3
2017-03-27 15:13:38 PDT
Could we display the connection status icon in the subtitle part of the tree element? (we'd want to hide the em-dash separator if we tried this)
Joseph Pecoraro
Comment 4
2017-04-03 11:28:26 PDT
Comment on
attachment 305513
[details]
Patch r=me, This sounds fine to me.
WebKit Commit Bot
Comment 5
2017-04-03 14:26:13 PDT
Comment on
attachment 305513
[details]
Patch Clearing flags on attachment: 305513 Committed
r214839
: <
http://trac.webkit.org/changeset/214839
>
WebKit Commit Bot
Comment 6
2017-04-03 14:26:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug