Bug 170093 – Add API to get available content extension identifiers in a WKContentExtensionStore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alex Christensen]

Based on API review feedback, this would make sense to have.

[Alex Christensen]

Created attachment 305352 [details]
patch

[Geoffrey Garen]

Comment on attachment 305352 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305352&action=review

r=me

> Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp:404
> +            completionHandler(identifiers);

I think you need to WTFMove(identifiers) again in this argument expression or you will copy the vector. (The capture expression creates an rvalue reference by WTFMove, but immediately assigns that reference to an lvalue named "identifiers".)

> Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.mm:115
> +        NSMutableArray<NSString *> *nsIdentifiers = [NSMutableArray arrayWithCapacity:100];

Why not use the capacity in identifiers?

[Alex Christensen]

Comment on attachment 305352 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305352&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.mm:115
>> +        NSMutableArray<NSString *> *nsIdentifiers = [NSMutableArray arrayWithCapacity:100];
> 
> Why not use the capacity in identifiers?

100 ought to be enough for anyone.
JK, this should obviously be the actual capacity.

[Alex Christensen]

Created attachment 306760 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r215209